Skip to content

Adding Workflow for also build Windows-based wheels#37

Merged
birkholz-cubert merged 14 commits into
mainfrom
feature/add_windows_github_runners
Jun 22, 2026
Merged

Adding Workflow for also build Windows-based wheels#37
birkholz-cubert merged 14 commits into
mainfrom
feature/add_windows_github_runners

Conversation

@birkholz-cubert

Copy link
Copy Markdown
Collaborator

No description provided.

The cmake step relied on $ENV{PROGRAMFILES} in FindCuvis.cmake to
find the SDK at C:\Program Files\Cuvis\bin. On the current Windows
runner image this expansion may not resolve correctly. Passing
CMAKE_PREFIX_PATH explicitly makes cmake search the SDK bin
directory directly, bypassing the env-var lookup.
- Add C:\Program Files\Cuvis\bin to PATH in cmake step so the
  version-check binary compiled by try_run can load cuvis.dll
- Use python -m pip instead of pip to avoid WinError 5 access
  denied on pip.exe self-upgrade (Python 3.9 on Windows)
…talled files

Caching C:\Program Files\Cuvis and restoring it in a downstream job
does not replicate the registry entries and PATH changes the installer
makes, so cmake's try_run version check could not load cuvis.dll.

Instead: setup-windows-deps now only caches the installer zip at a
workspace-relative path (reliable to restore). Each build-and-test-
windows matrix job restores the zip and runs the full NSIS installer,
which sets up the complete system state needed by FindCuvis.cmake.

Keep CMAKE_PREFIX_PATH and PATH additions in the cmake step so the
current session sees the SDK regardless of when the installer's PATH
change propagates.
Python 3.9 reached EOL in Oct 2024 and is not installable via
actions/setup-python@v5 on Windows Server 2025 runners. Linux jobs
continue to cover 3.9 via deadsnakes PPA in Docker containers.
The bash version ran via Git Bash which swallowed the version output.
Now uses pwsh consistently with the rest of the Windows job steps.
@birkholz-cubert birkholz-cubert changed the title Adding windows specific workflow Adding Workflow for also build Windows-based wheels Jun 22, 2026
@birkholz-cubert birkholz-cubert merged commit 763666b into main Jun 22, 2026
31 checks passed
@birkholz-cubert birkholz-cubert deleted the feature/add_windows_github_runners branch June 22, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant